feat: add C implementation for `math/base/special/ellipj` #6965

anandkaranubc · 2025-05-09T19:46:30Z

Progresses #649

Description

What is the purpose of this pull request?

This pull request:

Adds the complete C implementation for math/base/special/ellipj

Related Issues

Does this pull request have any related issues?

This pull request:

Progresses [RFC]: Add C implementations to base special math functions (tracking issue) #649

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

stdlib-bot · 2025-05-09T19:48:52Z

Coverage Report

Package	Statements	Branches	Functions	Lines
math/base/special/ellipj	$\color{red}701/713$ $\color{green}+98.32\%$	$\color{red}32/34$ $\color{green}+94.12\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{red}701/713$ $\color{green}+98.32\%$

The above coverage report was generated for the changes in this PR.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

Signed-off-by: Karan Anand <[email protected]>

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

Planeshifter · 2025-06-11T16:17:18Z

lib/node_modules/@stdlib/math/base/special/ellipj/lib/cn.js

 * @returns {number} cn(u, m)
 *
 * @example
+* var cn = require( '@stdlib/math/base/special/ellipj' ).cn;


Why were these changes made?

We require package itself only in lib/index.js; my expected change here would have been to simply add the missing vars to the individual @examples.

Sure, sorry I wasn't aware about that. Reverting those changes.

I think this was probably the reason why I made these changes.

stdlib/lib/node_modules/@stdlib/math/base/special/ellipj/lib/sn.js

Lines 41 to 47 in c1ec14d

* var sn = require( '@stdlib/math/base/special/ellipj' ).sn;

* var v = sn( 0.3, 0.5 );

* // returns ~0.293

*

* @example

* v = sn( 0.0, 0.0 );

* // returns ~0.0

I will update this part of the code accordingly too.

Planeshifter · 2025-06-11T16:17:33Z

lib/node_modules/@stdlib/math/base/special/ellipj/lib/dn.js

 * @returns {number} dn(u, m)
 *
 * @example
+* var dn = require( '@stdlib/math/base/special/ellipj' ).dn;


Why were these changes made?

We require package itself only in lib/index.js; my expected change here would have been to simply add the missing vars to the individual @examples.

Planeshifter · 2025-06-11T16:17:45Z

lib/node_modules/@stdlib/math/base/special/ellipj/lib/am.js

 * @returns {number} Jacobi amplitude, `am`
 *
 * @example
+* var am = require( '@stdlib/math/base/special/ellipj' ).am;


Why were these changes made?

We require package itself only in lib/index.js; my expected change here would have been to simply add the missing vars to the individual @examples.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

lib/node_modules/@stdlib/math/base/special/ellipj/manifest.json

Signed-off-by: Philipp Burckhardt <[email protected]>

Planeshifter

Thanks, @anandkaranubc! Let's get it in. 🚀

stdlib-bot · 2025-06-12T00:41:56Z

PR Commit Message

feat: add C implementation for `math/base/special/ellipj`

PR-URL: https://github.com/stdlib-js/stdlib/pull/6965
Ref: https://github.com/stdlib-js/stdlib/issues/649

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Karan Anand <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

⚠️ Action Required: This PR references tracking issues. Please update the PR description to replace any "Closes", "Fixes", or "Resolves" keywords with "Ref" when referencing these issues.

anandkaranubc added 2 commits May 9, 2025 12:40

stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels May 9, 2025

anandkaranubc and others added 3 commits May 10, 2025 18:10

Update benchmark.native.js

7f14de6

Signed-off-by: Karan Anand <[email protected]>

Update native.js

eb9e58f

Signed-off-by: Karan Anand <[email protected]>

anandkaranubc added C Issue involves or relates to C. GSoC Google Summer of Code. gsoc: 2025 Google Summer of Code (2025). labels May 20, 2025

anandkaranubc added 2 commits June 10, 2025 20:28

Merge branch 'develop' into feat/ellipj

196d10b

Planeshifter reviewed Jun 11, 2025

View reviewed changes

anandkaranubc added 2 commits June 11, 2025 13:29

Merge branch 'develop' into feat/ellipj

fdac84b

Planeshifter reviewed Jun 12, 2025

View reviewed changes

lib/node_modules/@stdlib/math/base/special/ellipj/manifest.json Outdated Show resolved Hide resolved

Planeshifter reviewed Jun 12, 2025

View reviewed changes

lib/node_modules/@stdlib/math/base/special/ellipj/manifest.json Outdated Show resolved Hide resolved

Planeshifter reviewed Jun 12, 2025

View reviewed changes

lib/node_modules/@stdlib/math/base/special/ellipj/manifest.json Outdated Show resolved Hide resolved

chore: remove duplicate entries

50b7f83

Signed-off-by: Philipp Burckhardt <[email protected]>

Planeshifter approved these changes Jun 12, 2025

View reviewed changes

Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jun 12, 2025

stdlib-bot removed the Needs Review A pull request which needs code review. label Jun 12, 2025

Planeshifter merged commit 6ae353c into stdlib-js:develop Jun 12, 2025
29 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: add C implementation for `math/base/special/ellipj` #6965

feat: add C implementation for `math/base/special/ellipj` #6965

Uh oh!

anandkaranubc commented May 9, 2025

Uh oh!

stdlib-bot commented May 9, 2025 •

edited

Loading

Uh oh!

Planeshifter Jun 11, 2025

Uh oh!

anandkaranubc Jun 11, 2025

Uh oh!

anandkaranubc Jun 11, 2025

Uh oh!

Planeshifter Jun 11, 2025

Uh oh!

Planeshifter Jun 11, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Planeshifter left a comment

Uh oh!

stdlib-bot commented Jun 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	* var sn = require( '@stdlib/math/base/special/ellipj' ).sn;
	* var v = sn( 0.3, 0.5 );
	* // returns ~0.293
	*
	* @example
	* v = sn( 0.0, 0.0 );
	* // returns ~0.0

Uh oh!

feat: add C implementation for math/base/special/ellipj #6965

feat: add C implementation for math/base/special/ellipj #6965

Uh oh!

Conversation

anandkaranubc commented May 9, 2025

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Planeshifter Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

Planeshifter Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

Planeshifter Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented Jun 12, 2025

PR Commit Message

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: add C implementation for `math/base/special/ellipj` #6965

feat: add C implementation for `math/base/special/ellipj` #6965

stdlib-bot commented May 9, 2025 •

edited

Loading